fix: relaunch browser when launch options change (#996)

* fix: relaunch browser when launch options change (#993) When the daemon already held a running browser, handle_launch only checked connection type and liveness to decide reuse. Config changes like adding extensions to config.json were silently ignored. Store a hash of the relaunch-relevant LaunchOptions fields and compare on each launch command. If the hash differs the browser is closed and relaunched with the new options. * fmt * fix * fix * fmt --------- Co-authored-by: hyunjinee <leehj0110@kakao.com> Co-authored-by: ctate <366502+ctate@users.noreply.github.com>
2026-04-04 10:41:02 -05:00
parent 4b5ba9f245
commit 05d86fadf5
2 changed files with 189 additions and 97 deletions
@@ -3822,3 +3822,65 @@ async fn e2e_externally_opened_tab_detected() {
    let resp = execute_command(&json!({ "id": "99", "action": "close" }), &mut state).await;
    assert_success(&resp);
 }
+
+// ---------------------------------------------------------------------------
+// Regression: issue #993 — launch options change must trigger relaunch
+// ---------------------------------------------------------------------------
+
+/// When the browser is already running and a second launch command arrives with
+/// different options (e.g., extensions added), the daemon must relaunch the
+/// browser instead of silently reusing the old one.
+///
+/// Before the fix, `handle_launch` only checked connection type and liveness,
+/// so changed options like extensions were ignored and the old browser was reused.
+#[tokio::test]
+#[ignore]
+async fn e2e_relaunch_on_options_change() {
+    let mut state = DaemonState::new();
+
+    // First launch — headless, no extensions.
+    let resp = execute_command(
+        &json!({ "id": "1", "action": "launch", "headless": true }),
+        &mut state,
+    )
+    .await;
+    assert_success(&resp);
+    assert_eq!(get_data(&resp)["launched"], true);
+    assert!(
+        get_data(&resp).get("reused").is_none(),
+        "first launch must not be a reuse"
+    );
+
+    // Second launch — same options → should reuse.
+    let resp = execute_command(
+        &json!({ "id": "2", "action": "launch", "headless": true }),
+        &mut state,
+    )
+    .await;
+    assert_success(&resp);
+    assert_eq!(
+        get_data(&resp)["reused"],
+        true,
+        "identical options must reuse the browser"
+    );
+
+    // Third launch — different options (extensions added) → must relaunch, not reuse.
+    let resp = execute_command(
+        &json!({
+            "id": "3",
+            "action": "launch",
+            "headless": false,
+            "extensions": ["/tmp/fake-extension"]
+        }),
+        &mut state,
+    )
+    .await;
+    assert_success(&resp);
+    assert!(
+        get_data(&resp).get("reused").is_none(),
+        "changed options must trigger a relaunch, not reuse (issue #993)"
+    );
+
+    let resp = execute_command(&json!({ "id": "99", "action": "close" }), &mut state).await;
+    assert_success(&resp);
+}