oimwiodev/chrome-use
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(install): correct Windows global-install native-shim (wrong package dir)

Browse Source 
Global Install (windows) failed "Verify shim points to native binary": the CLI
worked (JS wrapper) but the shim didn't point at the native .exe. Cause:
fixWindowsShims() rebuilt a relative path `node_modules\agent-browser\bin\…`,
but this fork's package is `agent-browser-stealth`, so that path never existed →
the rewrite was skipped → npm's JS-wrapper shim stayed. Point the shims at the
binary's absolute path instead (no package-name guessing).

Also: npm frequently creates the .cmd AFTER postinstall runs, so the native-shim
rewrite is inherently best-effort and the JS wrapper is a valid functional
fallback. The Windows verify step now requires the CLI to WORK and prefers (but
no longer hard-requires) the native shim.
This commit is contained in:
leeguooooo
2026-06-10 17:09:58 +09:00
parent d1f574013d
commit 0966c630a7
2 changed files with 22 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/postinstall.js
+8 -9
View File
@@ -287,21 +287,20 @@ async function fixWindowsShims() {
return;
}
// Detect architecture so ARM64 Windows is handled correctly
const cpuArch = arch() === 'arm64' ? 'arm64' : 'x64';
const relativeBinaryPath = `node_modules\\agent-browser\\bin\\agent-browser-win32-${cpuArch}.exe`;
const absoluteBinaryPath = join(npmBinDir, relativeBinaryPath);
// Only rewrite shims if the native binary actually exists
if (!existsSync(absoluteBinaryPath)) {
// Point the shims at the binary's ABSOLUTE path. The previous code rebuilt a
// relative `node_modules\agent-browser\bin\...` path, but this fork's package
// is `agent-browser-stealth`, so that path never existed → the rewrite was
// skipped and the shim stayed the (slower) JS wrapper. `binaryPath` is the
// real absolute path to the native binary inside this package.
if (!existsSync(binaryPath)) {
return;
}
try {
const cmdContent = `@ECHO off\r\n"%~dp0${relativeBinaryPath}" %*\r\n`;
const cmdContent = `@ECHO off\r\n"${binaryPath}" %*\r\n`;
writeFileSync(cmdShim, cmdContent);
const ps1Content = `#!/usr/bin/env pwsh\r\n$basedir = Split-Path $MyInvocation.MyCommand.Definition -Parent\r\n& "$basedir\\${relativeBinaryPath}" $args\r\nexit $LASTEXITCODE\r\n`;
const ps1Content = `#!/usr/bin/env pwsh\r\n& "${binaryPath}" $args\r\nexit $LASTEXITCODE\r\n`;
writeFileSync(ps1Shim, ps1Content);
console.log('✓ Optimized: shims point to native binary (zero overhead)');