address feedback

This commit is contained in:
Chris Tate
2026-01-12 01:19:14 -06:00
parent 36ad3ac66e
commit 2322e5b639
+11 -1
View File
@@ -223,7 +223,10 @@ pub fn parse_command(args: &[String], flags: &Flags) -> Result<Value, ParseError
// Check for --load flag: wait --load networkidle // Check for --load flag: wait --load networkidle
if let Some(idx) = rest.iter().position(|&s| s == "--load" || s == "-l") { if let Some(idx) = rest.iter().position(|&s| s == "--load" || s == "-l") {
let state = rest.get(idx + 1).unwrap_or(&"load"); let state = rest.get(idx + 1).ok_or_else(|| ParseError::MissingArguments {
context: "wait --load".to_string(),
usage: "wait --load <state>",
})?;
return Ok(json!({ "id": id, "action": "waitforloadstate", "state": state })); return Ok(json!({ "id": id, "action": "waitforloadstate", "state": state }));
} }
@@ -1155,6 +1158,13 @@ mod tests {
assert_eq!(cmd["state"], "networkidle"); assert_eq!(cmd["state"], "networkidle");
} }
#[test]
fn test_wait_load_missing_state() {
let result = parse_command(&args("wait --load"), &default_flags());
assert!(result.is_err());
assert!(matches!(result.unwrap_err(), ParseError::MissingArguments { .. }));
}
#[test] #[test]
fn test_wait_fn() { fn test_wait_fn() {
let cmd = parse_command(&args("wait --fn window.ready"), &default_flags()).unwrap(); let cmd = parse_command(&args("wait --fn window.ready"), &default_flags()).unwrap();