fix: recover GitHub release when npm published but release creation failed (#1168)
check-release now detects when the npm version matches but the GitHub release is missing. build-binaries and github-release run in that case so binaries, dashboard, and release notes are created without requiring a version bump.
This commit is contained in:
@@ -17,12 +17,13 @@ jobs:
|
|||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
outputs:
|
outputs:
|
||||||
should_release: ${{ steps.check.outputs.should_release }}
|
should_release: ${{ steps.check.outputs.should_release }}
|
||||||
|
needs_github_release: ${{ steps.check.outputs.needs_github_release }}
|
||||||
version: ${{ steps.check.outputs.version }}
|
version: ${{ steps.check.outputs.version }}
|
||||||
steps:
|
steps:
|
||||||
- name: Checkout repository
|
- name: Checkout repository
|
||||||
uses: actions/checkout@v4
|
uses: actions/checkout@v4
|
||||||
|
|
||||||
- name: Compare package.json version to npm
|
- name: Compare package.json version to npm and check GitHub release
|
||||||
id: check
|
id: check
|
||||||
run: |
|
run: |
|
||||||
LOCAL_VERSION=$(node -p "require('./package.json').version")
|
LOCAL_VERSION=$(node -p "require('./package.json').version")
|
||||||
@@ -34,16 +35,30 @@ jobs:
|
|||||||
if [ "$LOCAL_VERSION" != "$NPM_VERSION" ]; then
|
if [ "$LOCAL_VERSION" != "$NPM_VERSION" ]; then
|
||||||
echo "Version changed: $NPM_VERSION -> $LOCAL_VERSION"
|
echo "Version changed: $NPM_VERSION -> $LOCAL_VERSION"
|
||||||
echo "should_release=true" >> "$GITHUB_OUTPUT"
|
echo "should_release=true" >> "$GITHUB_OUTPUT"
|
||||||
|
echo "needs_github_release=true" >> "$GITHUB_OUTPUT"
|
||||||
else
|
else
|
||||||
echo "Version unchanged, skipping release"
|
echo "Version unchanged on npm, skipping build and publish"
|
||||||
echo "should_release=false" >> "$GITHUB_OUTPUT"
|
echo "should_release=false" >> "$GITHUB_OUTPUT"
|
||||||
|
|
||||||
|
# Check if GitHub release exists; it may be missing if a prior run
|
||||||
|
# published to npm but failed before creating the release.
|
||||||
|
TAG="v$LOCAL_VERSION"
|
||||||
|
if gh release view "$TAG" &>/dev/null; then
|
||||||
|
echo "GitHub release $TAG exists"
|
||||||
|
echo "needs_github_release=false" >> "$GITHUB_OUTPUT"
|
||||||
|
else
|
||||||
|
echo "GitHub release $TAG is missing, will rebuild and create it"
|
||||||
|
echo "needs_github_release=true" >> "$GITHUB_OUTPUT"
|
||||||
|
fi
|
||||||
fi
|
fi
|
||||||
echo "version=$LOCAL_VERSION" >> "$GITHUB_OUTPUT"
|
echo "version=$LOCAL_VERSION" >> "$GITHUB_OUTPUT"
|
||||||
|
env:
|
||||||
|
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
||||||
|
|
||||||
build-binaries:
|
build-binaries:
|
||||||
name: Build ${{ matrix.name }}
|
name: Build ${{ matrix.name }}
|
||||||
needs: check-release
|
needs: check-release
|
||||||
if: needs.check-release.outputs.should_release == 'true'
|
if: needs.check-release.outputs.should_release == 'true' || needs.check-release.outputs.needs_github_release == 'true'
|
||||||
runs-on: ${{ matrix.os }}
|
runs-on: ${{ matrix.os }}
|
||||||
strategy:
|
strategy:
|
||||||
fail-fast: false
|
fail-fast: false
|
||||||
@@ -168,6 +183,7 @@ jobs:
|
|||||||
publish:
|
publish:
|
||||||
name: Publish to npm
|
name: Publish to npm
|
||||||
needs: [check-release, build-binaries]
|
needs: [check-release, build-binaries]
|
||||||
|
if: needs.check-release.outputs.should_release == 'true'
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
steps:
|
steps:
|
||||||
- name: Checkout repository
|
- name: Checkout repository
|
||||||
@@ -242,7 +258,8 @@ jobs:
|
|||||||
|
|
||||||
github-release:
|
github-release:
|
||||||
name: Create GitHub Release
|
name: Create GitHub Release
|
||||||
needs: [check-release, publish]
|
needs: [check-release, build-binaries, publish]
|
||||||
|
if: always() && needs.build-binaries.result == 'success' && needs.check-release.outputs.needs_github_release == 'true'
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
steps:
|
steps:
|
||||||
- name: Checkout repository
|
- name: Checkout repository
|
||||||
|
|||||||
Reference in New Issue
Block a user