chore: add cargo fmt check to Rust CI and fix existing violations (#620)

TypeScript CI has prettier --check but Rust CI only runs cargo test.
Add cargo fmt --check to catch formatting issues early, and fix the
8 pre-existing formatting violations on main.

.github/workflows/ci.yml

@@ -64,12 +64,17 @@ jobs:
 
       - name: Setup Rust toolchain
         uses: dtolnay/rust-toolchain@stable
+        with:
+          components: rustfmt
 
       - name: Cache Rust build artifacts
         uses: Swatinem/rust-cache@v2
         with:
           workspaces: cli
 
+      - name: Format check
+        run: cargo fmt --manifest-path cli/Cargo.toml -- --check
+
       - name: Run Rust tests
         run: cargo test --profile ci --manifest-path cli/Cargo.toml
 

cli/src/connection.rs

@@ -533,15 +533,10 @@ pub fn ensure_daemon(session: &str, opts: &DaemonOptions) -> Result<DaemonResult
     #[cfg(unix)]
     let endpoint_info = format!(
         "socket: {}",
-        get_socket_dir()
+        get_socket_dir().join(format!("{}.sock", session)).display()
-            .join(format!("{}.sock", session))
-            .display()
     );
     #[cfg(windows)]
-    let endpoint_info = format!(
+    let endpoint_info = format!("port: 127.0.0.1:{}", get_port_for_session(session));
-        "port: 127.0.0.1:{}",
-        get_port_for_session(session)
-    );
 
     Err(format!("Daemon failed to start ({})", endpoint_info))
 }

cli/src/native/actions.rs

@@ -5181,7 +5181,10 @@ mod tests {
         let _guard = EnvGuard::new(&["AGENT_BROWSER_HEADED"]);
         _guard.set("AGENT_BROWSER_HEADED", "1");
         let opts = launch_options_from_env();
-        assert!(!opts.headless, "AGENT_BROWSER_HEADED=1 should set headless=false");
+        assert!(
+            !opts.headless,
+            "AGENT_BROWSER_HEADED=1 should set headless=false"
+        );
     }
 
     #[tokio::test]

cli/src/native/cdp/chrome.rs

@@ -137,8 +137,8 @@ fn build_chrome_args(options: &LaunchOptions) -> Result<ChromeArgs, String> {
         args.push(format!("--user-data-dir={}", expanded));
         None
     } else {
-        let dir = std::env::temp_dir()
+        let dir =
-            .join(format!("agent-browser-chrome-{}", uuid::Uuid::new_v4()));
+            std::env::temp_dir().join(format!("agent-browser-chrome-{}", uuid::Uuid::new_v4()));
         std::fs::create_dir_all(&dir)
             .map_err(|e| format!("Failed to create temp profile dir: {}", e))?;
         args.push(format!("--user-data-dir={}", dir.display()));
@@ -209,14 +209,11 @@ pub fn launch_chrome(options: &LaunchOptions) -> Result<ChromeProcess, String> {
             format!("Failed to launch Chrome at {:?}: {}", chrome_path, e)
         })?;
 
-    let stderr = child
+    let stderr = child.stderr.take().ok_or_else(|| {
-        .stderr
+        let _ = child.kill();
-        .take()
+        cleanup_temp_dir(&temp_user_data_dir);
-        .ok_or_else(|| {
+        "Failed to capture Chrome stderr".to_string()
-            let _ = child.kill();
+    })?;
-            cleanup_temp_dir(&temp_user_data_dir);
-            "Failed to capture Chrome stderr".to_string()
-        })?;
     let reader = BufReader::new(stderr);
 
     let ws_url = match wait_for_ws_url(reader) {
@@ -508,10 +505,7 @@ fn should_disable_sandbox(existing_args: &[String]) -> bool {
 
         // Generic container detection: cgroup contains docker/kubepods/lxc
         if let Ok(cgroup) = std::fs::read_to_string("/proc/1/cgroup") {
-            if cgroup.contains("docker")
+            if cgroup.contains("docker") || cgroup.contains("kubepods") || cgroup.contains("lxc") {
-                || cgroup.contains("kubepods")
-                || cgroup.contains("lxc")
-            {
                 return true;
             }
         }
@@ -655,10 +649,7 @@ mod tests {
 
     #[test]
     fn test_chrome_launch_error_generic() {
-        let lines = vec![
+        let lines = vec!["info line".to_string(), "another info line".to_string()];
-            "info line".to_string(),
-            "another info line".to_string(),
-        ];
         let msg = chrome_launch_error("Chrome exited", &lines);
         assert!(msg.contains("last 2 lines"));
     }
@@ -679,10 +670,7 @@ mod tests {
         };
         let result = build_chrome_args(&opts).unwrap();
         assert!(result.args.iter().any(|a| a == "--headless=new"));
-        assert!(result
+        assert!(result.args.iter().any(|a| a == "--window-size=1280,720"));
-            .args
-            .iter()
-            .any(|a| a == "--window-size=1280,720"));
         // Temp dir created when no profile
         assert!(result.temp_user_data_dir.is_some());
         let dir = result.temp_user_data_dir.unwrap();
@@ -741,14 +729,8 @@ mod tests {
             ..Default::default()
         };
         let result = build_chrome_args(&opts).unwrap();
-        assert!(!result
+        assert!(!result.args.iter().any(|a| a == "--window-size=1280,720"));
-            .args
+        assert!(result.args.iter().any(|a| a == "--window-size=1920,1080"));
-            .iter()
-            .any(|a| a == "--window-size=1280,720"));
-        assert!(result
-            .args
-            .iter()
-            .any(|a| a == "--window-size=1920,1080"));
         if let Some(ref dir) = result.temp_user_data_dir {
             let _ = std::fs::remove_dir_all(dir);
         }