fix: polish two Hermes follow-up cosmetics (invalid-selector wording, empty url glob)
Release binaries / Build macOS ARM64 (push) Has been cancelled
Release binaries / Build macOS x64 (push) Has been cancelled
Release binaries / Build Linux ARM64 (push) Has been cancelled
Release binaries / Build Linux musl ARM64 (push) Has been cancelled
Release binaries / Build Linux musl x64 (push) Has been cancelled
Release binaries / Build Linux x64 (push) Has been cancelled
Release binaries / Build Windows x64 (push) Has been cancelled
Release binaries / Attach binaries to GitHub Release (push) Has been cancelled

- invalid CSS selector now errors "Invalid selector '<sel>': <reason>" instead of
  the misleading "Element not found" — the coordinate path (resolve_by_selector)
  now also inspects exception_details, matching resolve_element_object_id.
- `wait --url ""` is rejected at parse time ("needs a non-empty pattern") rather
  than silently matching any URL. Unit test added.

Not changed: verb-less `find role X` defaulting to a click. That default is a
deliberate, tested decision (test_find_role_default_subaction_click_when_no_action);
changing it to locate-and-report is a design choice left to the maintainer.
This commit is contained in:
leeguooooo
2026-06-10 15:12:34 +09:00
parent cf4c27d13d
commit 9b1f98b966
5 changed files with 26 additions and 3 deletions
+17
View File
@@ -548,6 +548,14 @@ fn parse_command_inner(args: &[String], flags: &Flags) -> Result<Value, ParseErr
context: "wait --url".to_string(),
usage: "wait --url <pattern>",
})?;
if url.is_empty() {
return Err(ParseError::InvalidValue {
message: "wait --url needs a non-empty pattern (an empty pattern would \
match any URL)."
.to_string(),
usage: "wait --url <pattern>",
});
}
let mut cmd = json!({ "id": id, "action": "waitforurl", "url": url });
// Parse --timeout (without it the default applies — and a
// non-matching pattern would otherwise wait the full default).
@@ -3811,6 +3819,15 @@ mod tests {
assert_eq!(cmd["url"], "**/dashboard");
}
#[test]
fn test_wait_url_empty_pattern_rejected() {
// An empty pattern would match any URL — reject it rather than silently
// always-match. (Build argv directly: split_whitespace can't yield "".)
let argv = vec!["wait".to_string(), "--url".to_string(), String::new()];
let err = parse_command(&argv, &default_flags());
assert!(err.is_err(), "empty --url pattern should be rejected");
}
#[test]
fn test_wait_url_with_timeout() {
// --timeout must be parsed for the --url path; without it a non-matching