oimwiodev/chrome-use
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat: enhance snapshot usability by reducing AI cognitive load of semantic noise and -C flag (#968)

Browse Source 
* fix: add ref for cursor-interactive content roles

* fix: format

* feat: always include cursor-interactive elements in snapshot, -C is deprecated

* feat: process StaticText aggregation and deduplication

* update test

* clean up

* fix: escape text of elements in snapshot

* fix: redundant slicing

* fix: cargo fmt

* feat: deduplicate redundant StaticText

---------

Co-authored-by: 羲洋 <lipengyang.lpy@alibaba-inc.com>
This commit is contained in:
Lppy
2026-03-23 09:35:43 -05:00
committed by GitHub
co-authored by 羲洋
parent 9c0955ca99
commit b48c3e9dd2
11 changed files with 160 additions and 116 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cli/src/native/e2e_tests.rs
+16 -21
View File
@@ -2274,12 +2274,12 @@ async fn e2e_material_checkbox_check_uncheck() {
// ---------------------------------------------------------------------------
// Issue #841 – snapshot -C and screenshot --annotate must not hang over WSS
// (PS: -C is deprecated, cursor-interactive elements are referred by default now)
// ---------------------------------------------------------------------------
/// Verifies that `snapshot -C` (cursor-interactive mode) detects elements with
/// cursor:pointer / onclick / tabindex, produces the correct v0.19.0-compatible
/// output format, deduplicates against the ARIA tree, and completes in bounded
/// time (no sequential CDP round-trip explosion).
/// Verifies that `snapshot` detects elements with cursor:pointer / onclick / tabindex,
/// produces the correct v0.19.0-compatible output format, deduplicates against the ARIA
/// tree, and completes in bounded time (no sequential CDP round-trip explosion).
#[tokio::test]
#[ignore]
async fn e2e_snapshot_cursor_interactive() {
@@ -2293,7 +2293,7 @@ async fn e2e_snapshot_cursor_interactive() {
assert_success(&resp);
// Page with:
// - <button> and <a> (standard interactive – ARIA tree, NOT in cursor section)
// - <button> and <a> (standard interactive – ARIA tree)
// - <div cursor:pointer onclick> (clickable – cursor section)
// - <div tabindex=0> (focusable – cursor section)
// - <span cursor:pointer> (clickable – cursor section)
@@ -2316,10 +2316,10 @@ async fn e2e_snapshot_cursor_interactive() {
.await;
assert_success(&resp);
// snapshot -i -C: interactive tree + cursor section
// snapshot -i: interactive tree
let start = std::time::Instant::now();
let resp = execute_command(
&json!({ "id": "3", "action": "snapshot", "interactive": true, "cursor": true }),
&json!({ "id": "3", "action": "snapshot", "interactive": true }),
&mut state,
)
.await;
@@ -2366,7 +2366,7 @@ async fn e2e_snapshot_cursor_interactive() {
// Must complete quickly (< 5s), not hit the 30s CDP timeout
assert!(
elapsed.as_secs() < 5,
"snapshot -C took {:?}, expected < 5s (Issue #841 regression)",
"snapshot took {:?}, expected < 5s (Issue #841 regression)",
elapsed,
);
@@ -2433,7 +2433,7 @@ async fn e2e_screenshot_annotate_many_elements() {
assert_success(&resp);
}
/// Verifies `snapshot -C` with many cursor-interactive elements completes in
/// Verifies `snapshot` with many cursor-interactive elements completes in
/// bounded time. Direct regression test for Issue #841's root cause: N×2
/// sequential CDP round-trips per cursor-interactive element.
#[tokio::test]
@@ -2468,7 +2468,7 @@ async fn e2e_snapshot_cursor_many_elements() {
let start = std::time::Instant::now();
let resp = execute_command(
&json!({ "id": "3", "action": "snapshot", "interactive": true, "cursor": true }),
&json!({ "id": "3", "action": "snapshot", "interactive": true }),
&mut state,
)
.await;
@@ -2492,7 +2492,7 @@ async fn e2e_snapshot_cursor_many_elements() {
// Must complete quickly
assert!(
elapsed.as_secs() < 10,
"snapshot -C with 100 cursor elements took {:?}, expected < 10s (Issue #841)",
"snapshot with 100 cursor elements took {:?}, expected < 10s (Issue #841)",
elapsed,
);
@@ -2504,7 +2504,7 @@ async fn e2e_snapshot_cursor_many_elements() {
/// the actual text content from parent elements.
#[tokio::test]
#[ignore]
async fn e2e_snapshot_inline_text_box_filtered() {
async fn e2e_snapshot_continuous_static_text() {
let mut state = DaemonState::new();
let resp = execute_command(
@@ -2514,7 +2514,7 @@ async fn e2e_snapshot_inline_text_box_filtered() {
.await;
assert_success(&resp);
// Simple HTML with text content that would generate InlineTextBox nodes
// Simple HTML with text content that would generate InlineTextBox nodes and sperate to multiple StaticText nodes
let html =
"data:text/html,<html><body><div><span>Hello</span> <span>World</span></div></body></html>";
@@ -2525,7 +2525,7 @@ async fn e2e_snapshot_inline_text_box_filtered() {
.await;
assert_success(&resp);
// Take snapshot to capture full output and verify InlineTextBox filtering
// Take snapshot to capture full output and verify InlineTextBox filtering and StaticText aggregation
let start = std::time::Instant::now();
let resp = execute_command(&json!({ "id": "3", "action": "snapshot" }), &mut state).await;
assert_success(&resp);
@@ -2542,13 +2542,8 @@ async fn e2e_snapshot_inline_text_box_filtered() {
// Verify that the actual text content is preserved
assert!(
snapshot_output.contains("Hello"),
"Snapshot should contain 'Hello': {}",
snapshot_output
);
assert!(
snapshot_output.contains("World"),
"Snapshot should contain 'World': {}",
snapshot_output.contains("Hello World"),
"Snapshot should contain 'Hello World': {}",
snapshot_output
);