From c4a40033e0c8c8d84a2cb4619091669ba82b6ff1 Mon Sep 17 00:00:00 2001 From: "jin.2" Date: Sun, 15 Mar 2026 02:07:46 +0900 Subject: [PATCH] fix: correct e2e test assertions for diff_snapshot and domain_filter (#783) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - e2e_diff_snapshot: fix wrong field access (data.diff.identical → data.changed) and remove redundant assertion - e2e_domain_filter: set domain_filter after launch to avoid Fetch.enable deadlock Co-authored-by: hyunjinee --- cli/src/native/e2e_tests.rs | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/cli/src/native/e2e_tests.rs b/cli/src/native/e2e_tests.rs index 0a99dad..1238104 100644 --- a/cli/src/native/e2e_tests.rs +++ b/cli/src/native/e2e_tests.rs @@ -1226,7 +1226,6 @@ async fn e2e_state_management() { #[ignore] async fn e2e_domain_filter() { let mut state = DaemonState::new(); - state.domain_filter = Some(super::network::DomainFilter::new("example.com")); let resp = execute_command( &json!({ "id": "1", "action": "launch", "headless": true }), @@ -1235,6 +1234,9 @@ async fn e2e_domain_filter() { .await; assert_success(&resp); + // Set domain filter after launch to avoid Fetch.enable deadlock in tests. + state.domain_filter = Some(super::network::DomainFilter::new("example.com")); + // Allowed domain let resp = execute_command( &json!({ "id": "2", "action": "navigate", "url": "https://example.com" }), @@ -1304,12 +1306,8 @@ async fn e2e_diff_snapshot() { ) .await; assert_success(&resp); - let diff = &get_data(&resp)["diff"]; - assert_eq!(diff["identical"], false, "Diff should detect the h1 change"); - assert!( - diff["additions"].as_i64().unwrap() > 0 || diff["deletions"].as_i64().unwrap() > 0, - "Should have additions or deletions" - ); + let data = get_data(&resp); + assert_eq!(data["changed"], true, "Diff should detect the h1 change"); let resp = execute_command(&json!({ "id": "99", "action": "close" }), &mut state).await; assert_success(&resp);