fix(tabs): gate the about:blank cleanup to the relay only
CI / Version Sync Check (push) Has been cancelled
CI / Rust (push) Has been cancelled
CI / Rust (macos-latest - aarch64-apple-darwin) (push) Has been cancelled
CI / Rust (macos-latest - x86_64-apple-darwin) (push) Has been cancelled
CI / Rust (windows-latest - x86_64-pc-windows-msvc) (push) Has been cancelled
Release binaries / Build macOS ARM64 (push) Has been cancelled
Release binaries / Build macOS x64 (push) Has been cancelled
Release binaries / Build Linux ARM64 (push) Has been cancelled
Release binaries / Build Linux musl ARM64 (push) Has been cancelled
Release binaries / Build Linux musl x64 (push) Has been cancelled
Release binaries / Build Linux x64 (push) Has been cancelled
Release binaries / Build Windows x64 (push) Has been cancelled
CI / Native E2E Tests (push) Has been cancelled
CI / Windows Integration Test (push) Has been cancelled
CI / Global Install (macos-latest) (push) Has been cancelled
CI / Global Install (ubuntu-latest) (push) Has been cancelled
CI / Global Install (windows-latest) (push) Has been cancelled
Release binaries / Attach binaries to GitHub Release (push) Has been cancelled
CI / Version Sync Check (push) Has been cancelled
CI / Rust (push) Has been cancelled
CI / Rust (macos-latest - aarch64-apple-darwin) (push) Has been cancelled
CI / Rust (macos-latest - x86_64-apple-darwin) (push) Has been cancelled
CI / Rust (windows-latest - x86_64-pc-windows-msvc) (push) Has been cancelled
Release binaries / Build macOS ARM64 (push) Has been cancelled
Release binaries / Build macOS x64 (push) Has been cancelled
Release binaries / Build Linux ARM64 (push) Has been cancelled
Release binaries / Build Linux musl ARM64 (push) Has been cancelled
Release binaries / Build Linux musl x64 (push) Has been cancelled
Release binaries / Build Linux x64 (push) Has been cancelled
Release binaries / Build Windows x64 (push) Has been cancelled
CI / Native E2E Tests (push) Has been cancelled
CI / Windows Integration Test (push) Has been cancelled
CI / Global Install (macos-latest) (push) Has been cancelled
CI / Global Install (ubuntu-latest) (push) Has been cancelled
CI / Global Install (windows-latest) (push) Has been cancelled
Release binaries / Attach binaries to GitHub Release (push) Has been cancelled
The previous commit closed the leftover about:blank on ANY connection — but on a launched browser the initial about:blank is the browser's own first tab, not daemon scratch, so it must stay. Broke e2e_tab_ids_not_reused (launched). Gate the cleanup on agent_group().is_some() (relay only), where the about:blank is a tab WE created. e2e_tab_ids_not_reused passes; relay scratch-blank close intact.
This commit is contained in:
@@ -2073,8 +2073,10 @@ impl BrowserManager {
|
|||||||
// Close the daemon's leftover initial `about:blank` scratch tab once this
|
// Close the daemon's leftover initial `about:blank` scratch tab once this
|
||||||
// real tab exists, so the session's tab group isn't left showing a stray
|
// real tab exists, so the session's tab group isn't left showing a stray
|
||||||
// blank page beside the work tab (every group otherwise carried one). Only
|
// blank page beside the work tab (every group otherwise carried one). Only
|
||||||
// when opening a real url, and only OWNED, still-blank tabs.
|
// on the RELAY — there the about:blank is a tab WE created as scratch; on a
|
||||||
if target_url != "about:blank" {
|
// launched browser the initial about:blank is the browser's own first tab,
|
||||||
|
// which we must not close. Only when opening a real url, OWNED, still-blank.
|
||||||
|
if target_url != "about:blank" && self.agent_group().is_some() {
|
||||||
if let Some(new_tid) = self.pages.get(index).map(|p| p.target_id.clone()) {
|
if let Some(new_tid) = self.pages.get(index).map(|p| p.target_id.clone()) {
|
||||||
let blanks: Vec<String> = self
|
let blanks: Vec<String> = self
|
||||||
.pages
|
.pages
|
||||||
|
|||||||
Reference in New Issue
Block a user