oimwiodev/chrome-use
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ci: add clippy check to Rust CI workflow (#675)

Browse Source 
Add `cargo clippy -- -D warnings` step to the Rust CI job so that
clippy warnings fail the build. Also fix the one new lint
(`unnecessary_map_or`) introduced in the current stable clippy.

Fixes #672

Co-authored-by: hyunjinee <leehj0110@kakao.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
jin.2
2026-03-07 00:41:56 -06:00
committed by GitHub
co-authored by hyunjinee Claude Opus 4.6
parent aba2353112
commit d9387aae58
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/ci.yml
+4 -1
View File
@@ -65,7 +65,7 @@ jobs:
- name: Setup Rust toolchain - name: Setup Rust toolchain
uses: dtolnay/rust-toolchain@stable uses: dtolnay/rust-toolchain@stable
with: with:
components: rustfmt components: rustfmt, clippy
- name: Cache Rust build artifacts - name: Cache Rust build artifacts
uses: Swatinem/rust-cache@v2 uses: Swatinem/rust-cache@v2
@@ -75,6 +75,9 @@ jobs:
- name: Format check - name: Format check
run: cargo fmt --manifest-path cli/Cargo.toml -- --check run: cargo fmt --manifest-path cli/Cargo.toml -- --check
- name: Clippy check
run: cargo clippy --manifest-path cli/Cargo.toml -- -D warnings
- name: Run Rust tests - name: Run Rust tests
run: cargo test --profile ci --manifest-path cli/Cargo.toml run: cargo test --profile ci --manifest-path cli/Cargo.toml
cli/src/native/cdp/chrome.rs
+1 -1
View File
@@ -123,7 +123,7 @@ fn build_chrome_args(options: &LaunchOptions) -> Result<ChromeArgs, String> {
let has_extensions = options let has_extensions = options
.extensions .extensions
.as_ref() .as_ref()
.map_or(false, |exts| !exts.is_empty()); .is_some_and(|exts| !exts.is_empty());
// Extensions require headed mode in native Chrome (content scripts are not // Extensions require headed mode in native Chrome (content scripts are not
// injected in headless mode). Skip --headless when extensions are loaded. // injected in headless mode). Skip --headless when extensions are loaded.