oimwiodev/chrome-use
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: use getDefaultTimeout() in CDP connect paths instead of hardcoded 10s (#704)

Browse Source 
The connectViaCDP and connectToBrowserbase methods hardcoded
context.setDefaultTimeout(10000), ignoring the AGENT_BROWSER_DEFAULT_TIMEOUT
env var. This made page.goto time out after 10s on CDP connections even when
the env var was set to a higher value. Now both paths use getDefaultTimeout()
like all other connection modes.

Fixes #703
This commit is contained in:
Iddo Gino
2026-03-11 22:08:31 -05:00
committed by GitHub
parent 78c9aef3c9
commit db3d23d496
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/browser.ts
+3 -3
View File
@@ -34,7 +34,7 @@ import {
* Can be overridden via the AGENT_BROWSER_DEFAULT_TIMEOUT environment variable. * Can be overridden via the AGENT_BROWSER_DEFAULT_TIMEOUT environment variable.
* Default is 25s, which is below the CLI's 30s IPC read timeout to ensure * Default is 25s, which is below the CLI's 30s IPC read timeout to ensure
* Playwright errors are returned before the CLI gives up with EAGAIN. * Playwright errors are returned before the CLI gives up with EAGAIN.
* CDP and recording contexts use a shorter fixed timeout (10s) and are not affected. * Recording contexts use a shorter fixed timeout (10s) and are not affected.
*/ */
export function getDefaultTimeout(): number { export function getDefaultTimeout(): number {
const envValue = process.env.AGENT_BROWSER_DEFAULT_TIMEOUT; const envValue = process.env.AGENT_BROWSER_DEFAULT_TIMEOUT;
@@ -954,7 +954,7 @@ export class BrowserManager {
this.browserbaseSessionId = session.id; this.browserbaseSessionId = session.id;
this.browserbaseApiKey = browserbaseApiKey; this.browserbaseApiKey = browserbaseApiKey;
this.browser = browser; this.browser = browser;
context.setDefaultTimeout(10000); context.setDefaultTimeout(getDefaultTimeout());
this.contexts.push(context); this.contexts.push(context);
this.setupContextTracking(context); this.setupContextTracking(context);
await this.ensureDomainFilter(context); await this.ensureDomainFilter(context);
@@ -1559,7 +1559,7 @@ export class BrowserManager {
this.cdpEndpoint = cdpEndpoint; this.cdpEndpoint = cdpEndpoint;
for (const context of contexts) { for (const context of contexts) {
context.setDefaultTimeout(10000); context.setDefaultTimeout(getDefaultTimeout());
this.contexts.push(context); this.contexts.push(context);
this.setupContextTracking(context); this.setupContextTracking(context);
await this.ensureDomainFilter(context); await this.ensureDomainFilter(context);