fix: suppress spurious --native warning when set via env var (#611)
* fix: suppress spurious --native warning when set via env var When AGENT_BROWSER_NATIVE=1 is set via environment variable, every command after the first would warn: ⚠ --native ignored: daemon already running. This is a false positive — the daemon was already spawned in native mode and inherited the env var. The warning should only fire when --native is explicitly passed on the CLI to an already-running daemon. Add cli_native flag (consistent with existing cli_* pattern) to distinguish CLI origin from env var origin. * fix: add flag to test cfg * fix: cli_native should track flag presence, not value --native false on CLI should still warn when daemon is already running, since the user is explicitly trying to change the mode.
This commit is contained in:
@@ -2100,6 +2100,7 @@ mod tests {
|
|||||||
cli_allow_file_access: false,
|
cli_allow_file_access: false,
|
||||||
cli_annotate: false,
|
cli_annotate: false,
|
||||||
cli_download_path: false,
|
cli_download_path: false,
|
||||||
|
cli_native: false,
|
||||||
annotate: false,
|
annotate: false,
|
||||||
color_scheme: None,
|
color_scheme: None,
|
||||||
download_path: None,
|
download_path: None,
|
||||||
|
|||||||
@@ -250,6 +250,7 @@ pub struct Flags {
|
|||||||
pub cli_allow_file_access: bool,
|
pub cli_allow_file_access: bool,
|
||||||
pub cli_annotate: bool,
|
pub cli_annotate: bool,
|
||||||
pub cli_download_path: bool,
|
pub cli_download_path: bool,
|
||||||
|
pub cli_native: bool,
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn parse_flags(args: &[String]) -> Flags {
|
pub fn parse_flags(args: &[String]) -> Flags {
|
||||||
@@ -352,6 +353,7 @@ pub fn parse_flags(args: &[String]) -> Flags {
|
|||||||
cli_allow_file_access: false,
|
cli_allow_file_access: false,
|
||||||
cli_annotate: false,
|
cli_annotate: false,
|
||||||
cli_download_path: false,
|
cli_download_path: false,
|
||||||
|
cli_native: false,
|
||||||
};
|
};
|
||||||
|
|
||||||
let mut i = 0;
|
let mut i = 0;
|
||||||
@@ -568,6 +570,7 @@ pub fn parse_flags(args: &[String]) -> Flags {
|
|||||||
"--native" => {
|
"--native" => {
|
||||||
let (val, consumed) = parse_bool_arg(args, i);
|
let (val, consumed) = parse_bool_arg(args, i);
|
||||||
flags.native = val;
|
flags.native = val;
|
||||||
|
flags.cli_native = true;
|
||||||
if consumed {
|
if consumed {
|
||||||
i += 1;
|
i += 1;
|
||||||
}
|
}
|
||||||
|
|||||||
+1
-1
@@ -463,7 +463,7 @@ fn main() {
|
|||||||
flags.ignore_https_errors.then_some("--ignore-https-errors"),
|
flags.ignore_https_errors.then_some("--ignore-https-errors"),
|
||||||
flags.cli_allow_file_access.then_some("--allow-file-access"),
|
flags.cli_allow_file_access.then_some("--allow-file-access"),
|
||||||
flags.cli_download_path.then_some("--download-path"),
|
flags.cli_download_path.then_some("--download-path"),
|
||||||
flags.native.then_some("--native"),
|
flags.cli_native.then_some("--native"),
|
||||||
]
|
]
|
||||||
.into_iter()
|
.into_iter()
|
||||||
.flatten()
|
.flatten()
|
||||||
|
|||||||
Reference in New Issue
Block a user