oimwiodev/chrome-use
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: correct e2e test assertions for diff_snapshot and domain_filter (#783)

Browse Source 
- e2e_diff_snapshot: fix wrong field access (data.diff.identical →
  data.changed)
    and remove redundant assertion
  - e2e_domain_filter: set domain_filter after launch to avoid Fetch.enable
  deadlock

Co-authored-by: hyunjinee <leehj0110@kakao.com>
This commit is contained in:
jin.2
2026-03-14 12:07:46 -05:00
committed by GitHub
co-authored by hyunjinee
parent 1fa7949542
commit c4a40033e0
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cli/src/native/e2e_tests.rs
+5 -7
View File
@@ -1226,7 +1226,6 @@ async fn e2e_state_management() {
#[ignore]
async fn e2e_domain_filter() {
let mut state = DaemonState::new();
state.domain_filter = Some(super::network::DomainFilter::new("example.com"));
let resp = execute_command(
&json!({ "id": "1", "action": "launch", "headless": true }),
@@ -1235,6 +1234,9 @@ async fn e2e_domain_filter() {
.await;
assert_success(&resp);
// Set domain filter after launch to avoid Fetch.enable deadlock in tests.
state.domain_filter = Some(super::network::DomainFilter::new("example.com"));
// Allowed domain
let resp = execute_command(
&json!({ "id": "2", "action": "navigate", "url": "https://example.com" }),
@@ -1304,12 +1306,8 @@ async fn e2e_diff_snapshot() {
)
.await;
assert_success(&resp);
let diff = &get_data(&resp)["diff"];
assert_eq!(diff["identical"], false, "Diff should detect the h1 change");
assert!(
diff["additions"].as_i64().unwrap() > 0 || diff["deletions"].as_i64().unwrap() > 0,
"Should have additions or deletions"
);
let data = get_data(&resp);
assert_eq!(data["changed"], true, "Diff should detect the h1 change");
let resp = execute_command(&json!({ "id": "99", "action": "close" }), &mut state).await;
assert_success(&resp);