Compare commits
8
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
312bb0d65b | ||
|
|
cff003c333 | ||
|
|
f2b0c2ea9b | ||
|
|
ea58bce19e | ||
|
|
afb68ded93 | ||
|
|
a6631cd7d8 | ||
|
|
4f630e29ad | ||
|
|
d232763ff7 |
Generated
+1
-1
@@ -45,7 +45,7 @@ dependencies = [
|
||||
|
||||
[[package]]
|
||||
name = "agent-browser-stealth"
|
||||
version = "0.27.0-fork.19"
|
||||
version = "0.27.0-fork.23"
|
||||
dependencies = [
|
||||
"aes-gcm",
|
||||
"async-trait",
|
||||
|
||||
+1
-1
@@ -1,6 +1,6 @@
|
||||
[package]
|
||||
name = "agent-browser-stealth"
|
||||
version = "0.27.0-fork.19"
|
||||
version = "0.27.0-fork.23"
|
||||
edition = "2021"
|
||||
description = "Fast browser automation CLI for AI agents"
|
||||
license = "Apache-2.0"
|
||||
|
||||
+44
-13
@@ -399,9 +399,14 @@ pub fn run_nm_host() {
|
||||
|
||||
async fn nm_host_main() {
|
||||
use crate::native::relay::{RelayOut, RelayState};
|
||||
use std::collections::HashMap;
|
||||
use std::sync::atomic::{AtomicU64, Ordering};
|
||||
use std::sync::Arc;
|
||||
use tokio::io::{AsyncReadExt, AsyncWriteExt};
|
||||
use tokio::sync::{broadcast, mpsc, Mutex};
|
||||
use tokio::sync::{mpsc, Mutex};
|
||||
|
||||
/// client_id -> unbounded sender feeding that client's ws writer.
|
||||
type ClientMap = Arc<Mutex<HashMap<u64, mpsc::UnboundedSender<String>>>>;
|
||||
|
||||
nm_log(&format!(
|
||||
"[nm-host] start argv={:?}",
|
||||
@@ -432,7 +437,8 @@ async fn nm_host_main() {
|
||||
nm_log(&format!("[nm-host] cdp endpoint {url}"));
|
||||
|
||||
let state = Arc::new(Mutex::new(RelayState::new()));
|
||||
let (to_clients, _) = broadcast::channel::<String>(4096);
|
||||
let clients: ClientMap = Arc::new(Mutex::new(HashMap::new()));
|
||||
let next_client_id = Arc::new(AtomicU64::new(1));
|
||||
let (to_ext, mut to_ext_rx) = mpsc::channel::<Vec<u8>>(4096);
|
||||
|
||||
// Single writer to Chrome (extension) over stdout, native-messaging framed.
|
||||
@@ -450,7 +456,8 @@ async fn nm_host_main() {
|
||||
// Accept agent-browser CDP clients on the guid-scoped ws endpoint.
|
||||
{
|
||||
let state = state.clone();
|
||||
let to_clients = to_clients.clone();
|
||||
let clients = clients.clone();
|
||||
let next_client_id = next_client_id.clone();
|
||||
let to_ext = to_ext.clone();
|
||||
let guid = guid.clone();
|
||||
tokio::spawn(async move {
|
||||
@@ -460,11 +467,14 @@ async fn nm_host_main() {
|
||||
Err(_) => break,
|
||||
};
|
||||
let st = state.clone();
|
||||
let rx = to_clients.subscribe();
|
||||
let client_id = next_client_id.fetch_add(1, Ordering::Relaxed);
|
||||
let (ctx, crx) = mpsc::unbounded_channel::<String>();
|
||||
clients.lock().await.insert(client_id, ctx);
|
||||
let tx = to_ext.clone();
|
||||
let g = guid.clone();
|
||||
let cls = clients.clone();
|
||||
tokio::spawn(async move {
|
||||
handle_cdp_client(stream, g, st, rx, tx).await;
|
||||
handle_cdp_client(stream, g, st, client_id, crx, tx, cls).await;
|
||||
});
|
||||
}
|
||||
});
|
||||
@@ -492,8 +502,23 @@ async fn nm_host_main() {
|
||||
};
|
||||
for o in outs {
|
||||
match o {
|
||||
RelayOut::ToClient(m) => {
|
||||
let _ = to_clients.send(m.to_string());
|
||||
RelayOut::ToClient { to, msg } => {
|
||||
let text = msg.to_string();
|
||||
let cls = clients.lock().await;
|
||||
match to {
|
||||
// Command reply → only the client that issued it.
|
||||
Some(cid) => {
|
||||
if let Some(tx) = cls.get(&cid) {
|
||||
let _ = tx.send(text);
|
||||
}
|
||||
}
|
||||
// CDP event → fan out to every connected client.
|
||||
None => {
|
||||
for tx in cls.values() {
|
||||
let _ = tx.send(text.clone());
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
RelayOut::ToExt(m) => {
|
||||
let _ = to_ext.send(m.to_string().into_bytes()).await;
|
||||
@@ -505,16 +530,20 @@ async fn nm_host_main() {
|
||||
let _ = std::fs::remove_file(relay_url_path());
|
||||
}
|
||||
|
||||
#[allow(clippy::too_many_arguments)]
|
||||
async fn handle_cdp_client(
|
||||
stream: tokio::net::TcpStream,
|
||||
guid: String,
|
||||
state: std::sync::Arc<tokio::sync::Mutex<crate::native::relay::RelayState>>,
|
||||
mut from_relay: tokio::sync::broadcast::Receiver<String>,
|
||||
client_id: u64,
|
||||
mut from_relay: tokio::sync::mpsc::UnboundedReceiver<String>,
|
||||
to_ext: tokio::sync::mpsc::Sender<Vec<u8>>,
|
||||
clients: std::sync::Arc<
|
||||
tokio::sync::Mutex<std::collections::HashMap<u64, tokio::sync::mpsc::UnboundedSender<String>>>,
|
||||
>,
|
||||
) {
|
||||
use crate::native::relay::ClientRoute;
|
||||
use futures_util::{SinkExt, StreamExt};
|
||||
use tokio::sync::broadcast::error::RecvError;
|
||||
use tokio_tungstenite::tungstenite::Message;
|
||||
|
||||
let want_path = format!("/{guid}");
|
||||
@@ -542,9 +571,8 @@ async fn handle_cdp_client(
|
||||
loop {
|
||||
tokio::select! {
|
||||
relayed = from_relay.recv() => match relayed {
|
||||
Ok(text) => { if tx.send(Message::Text(text)).await.is_err() { break } }
|
||||
Err(RecvError::Lagged(_)) => continue,
|
||||
Err(RecvError::Closed) => break,
|
||||
Some(text) => { if tx.send(Message::Text(text)).await.is_err() { break } }
|
||||
None => break,
|
||||
},
|
||||
incoming = rx.next() => match incoming {
|
||||
Some(Ok(Message::Text(text))) => {
|
||||
@@ -552,7 +580,7 @@ async fn handle_cdp_client(
|
||||
Ok(v) => v,
|
||||
Err(_) => continue,
|
||||
};
|
||||
let route = { state.lock().await.route_client_command(&v) };
|
||||
let route = { state.lock().await.route_client_command(client_id, &v) };
|
||||
match route {
|
||||
ClientRoute::Local(reply) => {
|
||||
if tx.send(Message::Text(reply.to_string())).await.is_err() { break }
|
||||
@@ -567,5 +595,8 @@ async fn handle_cdp_client(
|
||||
},
|
||||
}
|
||||
}
|
||||
// Unregister and forget this client's in-flight commands.
|
||||
clients.lock().await.remove(&client_id);
|
||||
state.lock().await.drop_client(client_id);
|
||||
nm_log("[nm-host] cdp client disconnected");
|
||||
}
|
||||
|
||||
+8
-1
@@ -658,8 +658,15 @@ fn main() {
|
||||
if clean.get(1).map(|s| s.as_str()) == Some("connect") {
|
||||
match connect::relay_url() {
|
||||
Some(url) => {
|
||||
// The connect path reads `flags.cdp` (parsed from the original
|
||||
// argv, which was `extension connect` → None), NOT `clean`.
|
||||
// Without this the relay URL is dropped and we fall through to
|
||||
// auto-connect, grabbing some other Chrome (stale :9222) or
|
||||
// popping the remote-debug prompt. Point the daemon at the
|
||||
// relay explicitly.
|
||||
flags.cdp = Some(url.clone());
|
||||
flags.auto_connect = false;
|
||||
clean = vec!["connect".to_string(), url];
|
||||
// fall through to the normal connect handling below
|
||||
}
|
||||
None => {
|
||||
eprintln!(
|
||||
|
||||
@@ -12,6 +12,11 @@ use super::cdp::lightpanda::{launch_lightpanda, LightpandaLaunchOptions, Lightpa
|
||||
use super::cdp::types::*;
|
||||
use super::element::{resolve_element_object_id, RefMap};
|
||||
|
||||
/// The daemon's session name, set once at daemon start. Names the Chrome tab
|
||||
/// group that abs-created tabs land in when driving the user's real Chrome via
|
||||
/// the `ab-connect` extension, so each agent/session gets its own group.
|
||||
pub static DAEMON_SESSION: std::sync::OnceLock<String> = std::sync::OnceLock::new();
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Launch validation
|
||||
// ---------------------------------------------------------------------------
|
||||
@@ -568,12 +573,14 @@ impl BrowserManager {
|
||||
|
||||
if page_targets.is_empty() {
|
||||
// Create a new tab
|
||||
let agent_group = self.agent_group();
|
||||
let result: CreateTargetResult = self
|
||||
.client
|
||||
.send_command_typed(
|
||||
"Target.createTarget",
|
||||
&CreateTargetParams {
|
||||
url: "about:blank".to_string(),
|
||||
agent_group,
|
||||
},
|
||||
None,
|
||||
)
|
||||
@@ -958,12 +965,14 @@ impl BrowserManager {
|
||||
return Ok(());
|
||||
}
|
||||
|
||||
let agent_group = self.agent_group();
|
||||
let result: CreateTargetResult = self
|
||||
.client
|
||||
.send_command_typed(
|
||||
"Target.createTarget",
|
||||
&CreateTargetParams {
|
||||
url: "about:blank".to_string(),
|
||||
agent_group,
|
||||
},
|
||||
None,
|
||||
)
|
||||
@@ -1072,6 +1081,27 @@ impl BrowserManager {
|
||||
self.pages.iter().any(|p| p.label.as_deref() == Some(label))
|
||||
}
|
||||
|
||||
/// Chrome tab-group name for tabs this manager creates, or `None` when not
|
||||
/// driving the user's real Chrome via the `ab-connect` extension relay.
|
||||
///
|
||||
/// Grouping only makes sense on the shared real browser (one Chrome, many
|
||||
/// agents): each session's tabs go into its own group. On a launched / direct
|
||||
/// CDP browser the endpoint is strict, so we must NOT send the custom param —
|
||||
/// hence `None` there. We detect the relay by matching our `ws_url` against
|
||||
/// the live relay URL the native-messaging host published.
|
||||
fn agent_group(&self) -> Option<String> {
|
||||
let via_relay = crate::connect::relay_url().as_deref() == Some(self.ws_url.as_str());
|
||||
if !via_relay {
|
||||
return None;
|
||||
}
|
||||
let name = DAEMON_SESSION.get().map(String::as_str).unwrap_or("default");
|
||||
if name.is_empty() {
|
||||
None
|
||||
} else {
|
||||
Some(name.to_string())
|
||||
}
|
||||
}
|
||||
|
||||
pub async fn tab_new(
|
||||
&mut self,
|
||||
url: Option<&str>,
|
||||
@@ -1096,12 +1126,14 @@ impl BrowserManager {
|
||||
|
||||
let target_url = url.unwrap_or("about:blank");
|
||||
|
||||
let agent_group = self.agent_group();
|
||||
let result: CreateTargetResult = self
|
||||
.client
|
||||
.send_command_typed(
|
||||
"Target.createTarget",
|
||||
&CreateTargetParams {
|
||||
url: target_url.to_string(),
|
||||
agent_group,
|
||||
},
|
||||
None,
|
||||
)
|
||||
|
||||
@@ -106,7 +106,13 @@ pub struct TargetInfo {
|
||||
pub target_id: String,
|
||||
#[serde(rename = "type")]
|
||||
pub target_type: String,
|
||||
// Tolerate minimal targetInfo: the ab-connect relay's synthesized
|
||||
// Target.attachedToTarget (re-announce path) omits title/url, and real CDP
|
||||
// occasionally omits them too. Default to empty rather than fail the whole
|
||||
// Target.getTargets deserialize.
|
||||
#[serde(default)]
|
||||
pub title: String,
|
||||
#[serde(default)]
|
||||
pub url: String,
|
||||
pub attached: Option<bool>,
|
||||
pub browser_context_id: Option<String>,
|
||||
@@ -141,6 +147,12 @@ pub struct SetDiscoverTargetsParams {
|
||||
#[serde(rename_all = "camelCase")]
|
||||
pub struct CreateTargetParams {
|
||||
pub url: String,
|
||||
/// Non-CDP hint consumed only by the `ab-connect` extension: the Chrome
|
||||
/// tab-group name to drop the new tab into (per-session grouping on the
|
||||
/// shared real Chrome). `None` on the normal CDP path so a strict real-Chrome
|
||||
/// endpoint never receives an unknown parameter.
|
||||
#[serde(skip_serializing_if = "Option::is_none")]
|
||||
pub agent_group: Option<String>,
|
||||
}
|
||||
|
||||
#[derive(Debug, Deserialize)]
|
||||
|
||||
@@ -17,6 +17,10 @@ use super::state;
|
||||
use super::stream::StreamServer;
|
||||
|
||||
pub async fn run_daemon(session: &str) {
|
||||
// Record this daemon's session so tabs it opens on the shared real Chrome
|
||||
// (via the ab-connect extension) land in a per-session Chrome tab group.
|
||||
let _ = super::browser::DAEMON_SESSION.set(session.to_string());
|
||||
|
||||
let socket_dir = get_daemon_socket_dir();
|
||||
if !socket_dir.exists() {
|
||||
let _ = fs::create_dir_all(&socket_dir);
|
||||
|
||||
+143
-44
@@ -10,6 +10,17 @@
|
||||
//! extension as `forwardCDPCommand`. That keeps `CdpClient` and `browser.rs`
|
||||
//! unchanged.
|
||||
//!
|
||||
//! ## Multiple clients (concurrent agents on one shared browser)
|
||||
//!
|
||||
//! Several agent-browser daemons (one per `--session`) can connect to the same
|
||||
//! relay/Chrome at once. The extension is a single peer, so the relay must
|
||||
//! demultiplex: every forwarded command is re-keyed to a relay-global id mapped
|
||||
//! back to the originating client, and the extension's reply is routed to **only
|
||||
//! that client** (with its original id restored). Command ids from different
|
||||
//! clients therefore never collide, and one client never sees another's command
|
||||
//! replies. CDP *events* (no id) fan out to all clients, which ignore events for
|
||||
//! sessions they didn't attach.
|
||||
//!
|
||||
//! This module is the pure translation core (no I/O) so the protocol can be
|
||||
//! unit-tested; the tokio WebSocket server that drives it lives alongside.
|
||||
|
||||
@@ -20,6 +31,9 @@ use serde_json::{json, Value};
|
||||
/// Protocol version advertised in the connect handshake (matches the extension).
|
||||
pub const RELAY_PROTOCOL: i64 = 3;
|
||||
|
||||
/// Identifies one connected CDP client (agent-browser daemon) for routing.
|
||||
pub type ClientId = u64;
|
||||
|
||||
/// One target (tab) the extension has attached, as the relay tracks it.
|
||||
#[derive(Clone)]
|
||||
struct TargetEntry {
|
||||
@@ -27,27 +41,36 @@ struct TargetEntry {
|
||||
target_info: Value,
|
||||
}
|
||||
|
||||
/// Relay translation state: the set of targets the extension currently exposes.
|
||||
/// Relay translation state: the targets the extension exposes, plus the
|
||||
/// in-flight command map used to route extension replies back to the right
|
||||
/// client.
|
||||
#[derive(Default)]
|
||||
pub struct RelayState {
|
||||
/// targetId -> entry
|
||||
targets: HashMap<String, TargetEntry>,
|
||||
/// relay-global command id -> (client that sent it, its original id)
|
||||
pending: HashMap<i64, (ClientId, Value)>,
|
||||
/// monotonic source of relay-global command ids
|
||||
next_global_id: i64,
|
||||
}
|
||||
|
||||
/// What to do with a raw CDP command received from the `CdpClient`.
|
||||
/// What to do with a raw CDP command received from a `CdpClient`.
|
||||
#[derive(Debug, PartialEq)]
|
||||
pub enum ClientRoute {
|
||||
/// Answer locally; the value is a raw CDP response `{id, result}`.
|
||||
/// Answer locally; the value is a raw CDP response `{id, result}` to send
|
||||
/// back to the originating client only.
|
||||
Local(Value),
|
||||
/// Forward to the extension; the value is a `forwardCDPCommand` envelope.
|
||||
/// Forward to the extension; the value is a `forwardCDPCommand` envelope
|
||||
/// already re-keyed to a relay-global id.
|
||||
Forward(Value),
|
||||
}
|
||||
|
||||
/// An output the relay emits while handling an extension message.
|
||||
#[derive(Debug, PartialEq)]
|
||||
pub enum RelayOut {
|
||||
/// Send this raw CDP message to the `CdpClient`.
|
||||
ToClient(Value),
|
||||
/// Send this raw CDP message to clients. `to = Some(id)` targets one client
|
||||
/// (a command reply); `to = None` broadcasts (a CDP event).
|
||||
ToClient { to: Option<ClientId>, msg: Value },
|
||||
/// Send this envelope message back to the extension.
|
||||
ToExt(Value),
|
||||
}
|
||||
@@ -68,10 +91,16 @@ impl RelayState {
|
||||
json!({ "method": "ping" })
|
||||
}
|
||||
|
||||
/// Route a raw CDP command `{id, method, params?, sessionId?}` from the
|
||||
/// Forget a disconnected client's in-flight commands so its orphaned
|
||||
/// `pending` entries don't leak.
|
||||
pub fn drop_client(&mut self, client_id: ClientId) {
|
||||
self.pending.retain(|_, (cid, _)| *cid != client_id);
|
||||
}
|
||||
|
||||
/// Route a raw CDP command `{id, method, params?, sessionId?}` from a
|
||||
/// `CdpClient`: answer browser-level `Target.*` discovery locally, forward
|
||||
/// the rest to the extension.
|
||||
pub fn route_client_command(&self, raw: &Value) -> ClientRoute {
|
||||
/// the rest to the extension under a relay-global id keyed to `client_id`.
|
||||
pub fn route_client_command(&mut self, client_id: ClientId, raw: &Value) -> ClientRoute {
|
||||
let id = raw.get("id").cloned().unwrap_or(Value::Null);
|
||||
let method = raw.get("method").and_then(|m| m.as_str()).unwrap_or("");
|
||||
let params = raw.get("params").cloned().unwrap_or_else(|| json!({}));
|
||||
@@ -100,17 +129,23 @@ impl RelayState {
|
||||
})),
|
||||
}
|
||||
}
|
||||
// Everything else goes to the extension's chrome.debugger.
|
||||
_ => ClientRoute::Forward(json!({
|
||||
"id": id,
|
||||
"method": "forwardCDPCommand",
|
||||
"params": { "method": method, "params": params, "sessionId": session_id },
|
||||
})),
|
||||
// Everything else goes to the extension's chrome.debugger. Re-key the
|
||||
// id so this client's reply can be routed back unambiguously.
|
||||
_ => {
|
||||
self.next_global_id += 1;
|
||||
let gid = self.next_global_id;
|
||||
self.pending.insert(gid, (client_id, id));
|
||||
ClientRoute::Forward(json!({
|
||||
"id": gid,
|
||||
"method": "forwardCDPCommand",
|
||||
"params": { "method": method, "params": params, "sessionId": session_id },
|
||||
}))
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/// Handle one decoded message from the extension. Updates target state and
|
||||
/// returns the messages to emit (to the client and/or back to the
|
||||
/// returns the messages to emit (routed to a client and/or back to the
|
||||
/// extension). `expected_token` is matched against the connect handshake.
|
||||
pub fn handle_ext_message(&mut self, msg: &Value, expected_token: &str) -> Vec<RelayOut> {
|
||||
// Connect handshake request from the extension.
|
||||
@@ -137,12 +172,20 @@ impl RelayState {
|
||||
return vec![];
|
||||
}
|
||||
|
||||
// Response to a forwardCDPCommand we sent → raw CDP response to client.
|
||||
// Response to a forwardCDPCommand we sent → route the raw CDP response
|
||||
// back to the client that issued it, with its original id restored.
|
||||
if msg.get("id").is_some()
|
||||
&& (msg.get("result").is_some() || msg.get("error").is_some())
|
||||
&& msg.get("method").is_none()
|
||||
{
|
||||
let mut out = json!({ "id": msg.get("id").cloned().unwrap_or(Value::Null) });
|
||||
let gid = msg.get("id").and_then(|i| i.as_i64());
|
||||
let (to, orig_id) = match gid.and_then(|g| self.pending.remove(&g)) {
|
||||
Some((client_id, orig)) => (Some(client_id), orig),
|
||||
// No mapping (stale/unknown id) — fall back to broadcasting with
|
||||
// whatever id the extension echoed.
|
||||
None => (None, msg.get("id").cloned().unwrap_or(Value::Null)),
|
||||
};
|
||||
let mut out = json!({ "id": orig_id });
|
||||
if let Some(r) = msg.get("result") {
|
||||
out["result"] = r.clone();
|
||||
}
|
||||
@@ -153,7 +196,7 @@ impl RelayState {
|
||||
other => other.clone(),
|
||||
};
|
||||
}
|
||||
return vec![RelayOut::ToClient(out)];
|
||||
return vec![RelayOut::ToClient { to, msg: out }];
|
||||
}
|
||||
|
||||
// CDP event forwarded from a tab.
|
||||
@@ -194,12 +237,13 @@ impl RelayState {
|
||||
_ => {}
|
||||
}
|
||||
|
||||
// Regular CDP event → deliver to the client with its sessionId.
|
||||
// Regular CDP event → fan out to all clients (each filters by the
|
||||
// sessions it attached to).
|
||||
let mut ev = json!({ "method": inner_method, "params": inner_params });
|
||||
if let Some(sid) = session_id {
|
||||
ev["sessionId"] = json!(sid);
|
||||
}
|
||||
return vec![RelayOut::ToClient(ev)];
|
||||
return vec![RelayOut::ToClient { to: None, msg: ev }];
|
||||
}
|
||||
|
||||
vec![]
|
||||
@@ -247,7 +291,7 @@ mod tests {
|
||||
let out = s.handle_ext_message(&attached_event("T1", "cb-tab-1"), "tok");
|
||||
assert!(out.is_empty(), "attachedToTarget should be consumed, not forwarded");
|
||||
// Now getTargets must report it.
|
||||
let route = s.route_client_command(&json!({ "id": 1, "method": "Target.getTargets" }));
|
||||
let route = s.route_client_command(1, &json!({ "id": 1, "method": "Target.getTargets" }));
|
||||
match route {
|
||||
ClientRoute::Local(v) => {
|
||||
let infos = v["result"]["targetInfos"].as_array().unwrap();
|
||||
@@ -263,6 +307,7 @@ mod tests {
|
||||
let mut s = RelayState::new();
|
||||
s.seed_target("T1", "cb-tab-1");
|
||||
let route = s.route_client_command(
|
||||
7,
|
||||
&json!({ "id": 5, "method": "Target.attachToTarget", "params": { "targetId": "T1", "flatten": true } }),
|
||||
);
|
||||
assert_eq!(
|
||||
@@ -273,8 +318,9 @@ mod tests {
|
||||
|
||||
#[test]
|
||||
fn attach_to_unknown_target_errors_locally() {
|
||||
let s = RelayState::new();
|
||||
let mut s = RelayState::new();
|
||||
let route = s.route_client_command(
|
||||
1,
|
||||
&json!({ "id": 6, "method": "Target.attachToTarget", "params": { "targetId": "nope" } }),
|
||||
);
|
||||
match route {
|
||||
@@ -284,16 +330,17 @@ mod tests {
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn other_commands_forward_as_envelope() {
|
||||
let s = RelayState::new();
|
||||
let route = s.route_client_command(&json!({
|
||||
"id": 9, "method": "Page.navigate",
|
||||
"params": { "url": "https://x" }, "sessionId": "cb-tab-1"
|
||||
}));
|
||||
fn other_commands_forward_under_global_id() {
|
||||
let mut s = RelayState::new();
|
||||
let route = s.route_client_command(
|
||||
42,
|
||||
&json!({ "id": 9, "method": "Page.navigate", "params": { "url": "https://x" }, "sessionId": "cb-tab-1" }),
|
||||
);
|
||||
match route {
|
||||
ClientRoute::Forward(v) => {
|
||||
assert_eq!(v["method"], "forwardCDPCommand");
|
||||
assert_eq!(v["id"], 9);
|
||||
// id is re-keyed to a relay-global id (not the client's 9).
|
||||
assert_eq!(v["id"], 1);
|
||||
assert_eq!(v["params"]["method"], "Page.navigate");
|
||||
assert_eq!(v["params"]["sessionId"], "cb-tab-1");
|
||||
assert_eq!(v["params"]["params"]["url"], "https://x");
|
||||
@@ -303,30 +350,62 @@ mod tests {
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn forward_command_response_becomes_client_response() {
|
||||
fn reply_routes_back_to_the_issuing_client_with_original_id() {
|
||||
let mut s = RelayState::new();
|
||||
let out = s.handle_ext_message(&json!({ "id": 9, "result": { "frameId": "F1" } }), "tok");
|
||||
// Two clients each send a command that happens to share original id 1.
|
||||
let r1 = s.route_client_command(100, &json!({ "id": 1, "method": "Page.navigate", "params": {} }));
|
||||
let r2 = s.route_client_command(200, &json!({ "id": 1, "method": "Page.reload", "params": {} }));
|
||||
let g1 = match r1 {
|
||||
ClientRoute::Forward(v) => v["id"].as_i64().unwrap(),
|
||||
_ => panic!(),
|
||||
};
|
||||
let g2 = match r2 {
|
||||
ClientRoute::Forward(v) => v["id"].as_i64().unwrap(),
|
||||
_ => panic!(),
|
||||
};
|
||||
assert_ne!(g1, g2, "global ids must be distinct across clients");
|
||||
|
||||
// Extension replies for g2 → must go to client 200 with original id 1.
|
||||
let out = s.handle_ext_message(&json!({ "id": g2, "result": { "ok": true } }), "tok");
|
||||
assert_eq!(
|
||||
out,
|
||||
vec![RelayOut::ToClient(json!({ "id": 9, "result": { "frameId": "F1" } }))]
|
||||
vec![RelayOut::ToClient {
|
||||
to: Some(200),
|
||||
msg: json!({ "id": 1, "result": { "ok": true } })
|
||||
}]
|
||||
);
|
||||
// And g1 → client 100.
|
||||
let out = s.handle_ext_message(&json!({ "id": g1, "result": { "ok": false } }), "tok");
|
||||
assert_eq!(
|
||||
out,
|
||||
vec![RelayOut::ToClient {
|
||||
to: Some(100),
|
||||
msg: json!({ "id": 1, "result": { "ok": false } })
|
||||
}]
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn forward_command_error_is_wrapped() {
|
||||
fn forward_command_error_is_wrapped_and_routed() {
|
||||
let mut s = RelayState::new();
|
||||
let out = s.handle_ext_message(&json!({ "id": 9, "error": "boom" }), "tok");
|
||||
let r = s.route_client_command(5, &json!({ "id": 3, "method": "Page.navigate", "params": {} }));
|
||||
let gid = match r {
|
||||
ClientRoute::Forward(v) => v["id"].as_i64().unwrap(),
|
||||
_ => panic!(),
|
||||
};
|
||||
let out = s.handle_ext_message(&json!({ "id": gid, "error": "boom" }), "tok");
|
||||
match &out[0] {
|
||||
RelayOut::ToClient(v) => {
|
||||
assert_eq!(v["id"], 9);
|
||||
assert_eq!(v["error"]["message"], "boom");
|
||||
RelayOut::ToClient { to, msg } => {
|
||||
assert_eq!(*to, Some(5));
|
||||
assert_eq!(msg["id"], 3);
|
||||
assert_eq!(msg["error"]["message"], "boom");
|
||||
}
|
||||
_ => panic!("expected ToClient"),
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn regular_event_is_forwarded_with_session() {
|
||||
fn regular_event_broadcasts_with_session() {
|
||||
let mut s = RelayState::new();
|
||||
let ev = json!({
|
||||
"method": "forwardCDPEvent",
|
||||
@@ -335,14 +414,34 @@ mod tests {
|
||||
let out = s.handle_ext_message(&ev, "tok");
|
||||
assert_eq!(
|
||||
out,
|
||||
vec![RelayOut::ToClient(json!({
|
||||
"method": "Page.loadEventFired",
|
||||
"params": { "timestamp": 1.0 },
|
||||
"sessionId": "cb-tab-1"
|
||||
}))]
|
||||
vec![RelayOut::ToClient {
|
||||
to: None,
|
||||
msg: json!({
|
||||
"method": "Page.loadEventFired",
|
||||
"params": { "timestamp": 1.0 },
|
||||
"sessionId": "cb-tab-1"
|
||||
})
|
||||
}]
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn drop_client_clears_its_pending() {
|
||||
let mut s = RelayState::new();
|
||||
let r = s.route_client_command(9, &json!({ "id": 1, "method": "Page.navigate", "params": {} }));
|
||||
let gid = match r {
|
||||
ClientRoute::Forward(v) => v["id"].as_i64().unwrap(),
|
||||
_ => panic!(),
|
||||
};
|
||||
s.drop_client(9);
|
||||
// Reply now has no mapping → broadcast fallback (to: None), echoed id.
|
||||
let out = s.handle_ext_message(&json!({ "id": gid, "result": {} }), "tok");
|
||||
match &out[0] {
|
||||
RelayOut::ToClient { to, .. } => assert_eq!(*to, None),
|
||||
_ => panic!(),
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn connect_handshake_validates_token() {
|
||||
let mut s = RelayState::new();
|
||||
|
||||
@@ -119,6 +119,8 @@ async fn collect_storage_via_temp_target(
|
||||
"Target.createTarget",
|
||||
&CreateTargetParams {
|
||||
url: "about:blank".to_string(),
|
||||
// Transient internal target (storage collection) — never grouped.
|
||||
agent_group: None,
|
||||
},
|
||||
None,
|
||||
)
|
||||
|
||||
Binary file not shown.
Binary file not shown.
@@ -28,6 +28,46 @@ const tabs = new Map()
|
||||
const sessionToTab = new Map()
|
||||
/** child (OOPIF/worker) sessionId -> tabId */
|
||||
const childSessionToTab = new Map()
|
||||
/** tab-group name -> chrome tabGroups id (best-effort cache) */
|
||||
const groupIdByName = new Map()
|
||||
|
||||
// Deterministic color per group name so a given session keeps the same color.
|
||||
const GROUP_COLORS = ['blue', 'cyan', 'green', 'yellow', 'orange', 'red', 'pink', 'purple', 'grey']
|
||||
function colorForName(name) {
|
||||
let h = 0
|
||||
for (let i = 0; i < name.length; i++) h = (h * 31 + name.charCodeAt(i)) >>> 0
|
||||
return GROUP_COLORS[h % GROUP_COLORS.length]
|
||||
}
|
||||
|
||||
// Put a freshly-created tab into the agent/session's own Chrome tab group, so
|
||||
// each agent's tabs are visually separated (from each other and from the user's
|
||||
// own tabs) on the shared real browser. Best-effort: grouping failures never
|
||||
// break tab creation.
|
||||
async function groupTabInto(tabId, name) {
|
||||
if (!name || !chrome.tabGroups || !chrome.tabs.group) return
|
||||
const tab = await chrome.tabs.get(tabId).catch(() => null)
|
||||
if (!tab) return
|
||||
let gid = groupIdByName.get(name)
|
||||
if (gid != null) {
|
||||
const ok = await chrome.tabGroups.get(gid).then(() => true).catch(() => false)
|
||||
if (!ok) {
|
||||
gid = null
|
||||
groupIdByName.delete(name)
|
||||
}
|
||||
}
|
||||
if (gid == null) {
|
||||
// Reuse a same-titled group already in this window (survives SW restarts).
|
||||
const found = await chrome.tabGroups.query({ windowId: tab.windowId, title: name }).catch(() => [])
|
||||
if (found && found[0]) gid = found[0].id
|
||||
}
|
||||
if (gid == null) {
|
||||
gid = await chrome.tabs.group({ tabIds: tabId })
|
||||
await chrome.tabGroups.update(gid, { title: name, color: colorForName(name) }).catch(() => {})
|
||||
} else {
|
||||
await chrome.tabs.group({ groupId: gid, tabIds: tabId }).catch(() => {})
|
||||
}
|
||||
groupIdByName.set(name, gid)
|
||||
}
|
||||
|
||||
function postToHost(msg) {
|
||||
try {
|
||||
@@ -121,6 +161,13 @@ async function handleForwardCdpCommand(msg) {
|
||||
if (!tab.id) throw new Error('createTarget: no tab id')
|
||||
await new Promise((r) => setTimeout(r, 100))
|
||||
const t = await attachTab(tab.id)
|
||||
// Per-session tab grouping (non-CDP hint from the daemon). Best-effort.
|
||||
const group = typeof params?.agentGroup === 'string' ? params.agentGroup.trim() : ''
|
||||
if (group) {
|
||||
try {
|
||||
await groupTabInto(tab.id, group)
|
||||
} catch {}
|
||||
}
|
||||
return { targetId: t.targetId }
|
||||
}
|
||||
if (method === 'Target.closeTarget') {
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
{
|
||||
"manifest_version": 3,
|
||||
"name": "agent-browser connect",
|
||||
"version": "0.3.0",
|
||||
"version": "0.4.0",
|
||||
"description": "Let agent-browser drive your logged-in Chrome — install once, no token, no per-use confirmation.",
|
||||
"key": "MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA6vQIyscGIPYPZdSpPwPL0+0gxUROyRgCpmvCSDoc8XUm4qm97VbKnD9Ijc1lV22lNWZtE78gaRjt6BeSfuMgnBymnhLKjN1gU6AI5QUU0mrJyeHdWKvrKQR5FmsM2A7Xr1ykE2SiiS8zNUS3Y/6O5l+Nva7wrVy6E4a2dkBVQkOsu+DV+nEZvhIyuDY5D5SPXqNwUTWTaglwj5mjvHz36xSwCWlPmrtJ+ED0AUyrb2z4GIOmvk4kqtBVrh/UD058klLo4CkYOnIybB5aV6WYuwarfPY4bF/dLggPem+ewLNTUNBuwrxj/A4nUv0LJTuRO8rR7f8WR9qnRCY0Ic5saQIDAQAB",
|
||||
"icons": {
|
||||
@@ -13,6 +13,7 @@
|
||||
"permissions": [
|
||||
"debugger",
|
||||
"tabs",
|
||||
"tabGroups",
|
||||
"nativeMessaging",
|
||||
"storage",
|
||||
"alarms",
|
||||
|
||||
+1
-1
@@ -1,6 +1,6 @@
|
||||
{
|
||||
"name": "agent-browser-stealth",
|
||||
"version": "0.27.0-fork.19",
|
||||
"version": "0.27.0-fork.23",
|
||||
"description": "Browser automation CLI for AI agents \u2014 stealth fork with anti-detection",
|
||||
"type": "module",
|
||||
"packageManager": "pnpm@11.1.3",
|
||||
|
||||
Reference in New Issue
Block a user